Set dataobject on JmeJoint#703
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the JmeJoint constructor to accept and propagate a DataObject parameter, corrects a typo in the action name ('attachement' to 'attachment'), and ensures the DataObject is correctly set on child nodes in JmeSkinningControl. A critical issue was identified in JmeJoint.java where the instance field dataObject is incorrectly passed instead of the method parameter key2 during node creation, which could lead to uninitialized data objects.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…JmeJoint.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
I have no idea what I'm doing, but it seems to work.
Fixes #695